- Secret Money Generator
- Money Generator Runescape
- Bitcoin Free Online Generator
- Money Generator Paypal Account
- Buy Bitcoin Generator Software
Serial numbers for dscorpiohack bitcoin money generator: © 2006 - 2018 Serials.BE. Submit serial number.
Active9 months ago
Latest Update Bitcoin Money Adder 2017. About Bitcoin Adder 2017. PRICE: Serial Key price $10 for 1 PC license. BUY NOW with License Key. 1- To Purchase all together Bitcoin Adder 2017 & Generator Script software (2 in 1) instant download please click below: Pay amount. 0.025 BTC (plus miners fee). Bitcoin Generator 2014 v5.1.0 Incl Activation Key Free Download (No Survey or Password - Direct Link). Pc Optimizer Pro 7.1.0.8 Full Version Serial Key.
$begingroup$I wanted to learn how to create a Bitcoin wallet in code. I used as reference this guide which has code examples in JavaScript.
I wrote my implementation in Python. Here is the resulting code:
How to run:
I have my concerns about the correctness of the generated keys, as well as for the private key in WIF format. In theory it should be a short string.
Toby Speight31.3k77 gold badges4545 silver badges135135 bronze badges
Diego PinoDiego Pino
$endgroup$4 Answers
$begingroup$IMPORTANT!!!
Not a Python tip, but rather a MUST when it comes to sensitive information (quote from @nzall's comment):
Those private keys should NEVER, EVER be posted in a location even as remotely public as a code review site. More, replacing them is not enough. For all purposes, you should now view the original keys as compromised and must NEVER EVER EVER use them again for bitcoin storage. Doing so runs high risk of losing the bitcoins stored in them
I just made this tip a bit more seeable for everybody.
Another three small observations, in addition to what @Graipher said.
In Python you can 'chain' comparison operations which just means they are 'and'ed together.
In your case, it'd be like this:
Read more about it here
More, I'd recommend you use
.format()
when it comes to printing:Could be:
You should also have two blank lines between your functions (instead of a single one)
This:
Should be:
For more details / suggestions / improvements regarding your code layout, you could take a look at PEP8, Python's official style guide.
Grajdeanu Alex.Grajdeanu Alex.7,34122 gold badges2020 silver badges5858 bronze badges
$endgroup$$begingroup$
Three very small observations:
- In your function
generate_private_key_wif
, you never usehashed
, you re-compute it for the return value. - In a nice self-contained module like this one, you should definitely add
docstring
s to your functions. Have a look at PEP257 to see how they are defined. - You currently do
from ecdsa.keys import SigningKey
, but never use it. You also assignfrom_secret_exponent = ecdsa.keys.SigningKey.from_secret_exponent
in yourgenerate_private_key
function. Instead dofrom_secret_exponent = SigningKey.from_secret_exponent
or, probably better, split that line across two lines like this:
29.9k66 gold badges4747 silver badges104104 bronze badges
$endgroup$$begingroup$You have an error in WIF generation, you need to decode it from hex and take only 4 bytes for checksum, not 8:
Slava VSlava V
Secret Money Generator
$endgroup$Money Generator Runescape
$begingroup$Bitcoin Free Online Generator
The
generate_public_key
function's parameter is private key. I find the public key is generated by hashing private key in your code.Is it not wrong? I think the public key is generated by ecdsa.SECP256k1 using private key.Victor ChoyVictor Choy
$endgroup$protected by Community♦Oct 27 '18 at 10:34
Money Generator Paypal Account
Thank you for your interest in this question. Because it has attracted low-quality or spam answers that had to be removed, posting an answer now requires 10 reputation on this site (the association bonus does not count).
Would you like to answer one of these unanswered questions instead?
Would you like to answer one of these unanswered questions instead?